netvsp: adding LSO validation logic to handle_rndis_packet_message #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds LSO (Large Send Offload) packet validation logic to the netvsp driver's packet handling function to ensure guest-provided LSO packets meet required constraints.
Key changes:
- Adds validation for LSO packets to verify they have at least two SGEs (Scatter-Gather Elements)
- Validates that the first SGE is no larger than 256 bytes (header size constraint)
- Introduces a new error type for invalid LSO packets
vm/devices/net/netvsp/src/lib.rs
Outdated
| "LSO requires at least two SGEs", | ||
| )); | ||
| } | ||
| let first_segment_size = segments.first().unwrap().len; |
There was a problem hiding this comment.
Using unwrap() is unsafe here even though the length check exists above. If segments is empty, this will panic. Consider using segments[0].len instead since the length check guarantees at least 2 elements, or use a safer pattern like let first_segment = &segments[0];.
Suggested change
| let first_segment_size = segments.first().unwrap().len; | |
| let first_segment_size = segments[0].len; |
Brian-Perkins
previously approved these changes
Oct 13, 2025
chris-oo
reviewed
Oct 23, 2025
vm/devices/net/netvsp/src/lib.rs
Outdated
|
|
||
| if metadata.offload_tcp_segmentation { | ||
| if segments.len() < 2 { | ||
| return Err(WorkerError::InvalidLsoPacket( |
There was a problem hiding this comment.
should this be two different error types, and we log in the error how many segments we actually got?
vm/devices/net/netvsp/src/lib.rs
Outdated
| } | ||
| let first_segment_size = segments.first().unwrap().len; | ||
| if first_segment_size > 256 { | ||
| return Err(WorkerError::InvalidLsoPacket( |
There was a problem hiding this comment.
same with this below as above?
vm/devices/net/netvsp/src/lib.rs
Outdated
| "LSO requires at least two SGEs", | ||
| )); | ||
| } | ||
| let first_segment_size = segments.first().unwrap().len; |
erfrimod
force-pushed
the
erfrimod/netvsp-validate-lso-packets
branch
from
011988b to
7fe50de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
netvsp should be validating the LSO packets coming from the guest